-
Notifications
You must be signed in to change notification settings - Fork 751
telemetry(amazonq): add feedback functionality with thumbs up/down #6560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f7dae3 to
505ad34
Compare
|
…kit-vscode into feedback-functionality
laileni-aws
approved these changes
Feb 11, 2025
Contributor
laileni-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
dogusata
approved these changes
Feb 11, 2025
ashishrp-aws
approved these changes
Feb 11, 2025
laileni-aws
reviewed
Feb 12, 2025
packages/core/src/amazonqTest/chat/views/actions/uiMessageListener.ts
Outdated
Show resolved
Hide resolved
laileni-aws
reviewed
Feb 12, 2025
packages/amazonq/src/app/amazonqScan/chat/views/actions/uiMessageListener.ts
Outdated
Show resolved
Hide resolved
hayemaxi
approved these changes
Feb 12, 2025
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
…ws#6560) ## Problem - /test and /review are missing thumbs up/down telemetry - /test is missing feedback functionality <img width="545" alt="Screenshot 2025-02-11 at 1 58 42 PM" src="https://github.com/user-attachments/assets/11a46136-46a6-4d35-a7e1-e92f45b1034a" /> <img width="558" alt="Screenshot 2025-02-11 at 1 58 48 PM" src="https://github.com/user-attachments/assets/80288c37-a98c-4e8f-9e32-810238ee2695" /> ## Solution - send telemetry event for thumps up/down for /test and /review - send user feedback for /test which routes to SIM folder - No tests were added as this is UX change --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
feature/xbranches will not be squash-merged at release time.